Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate allow passing path or component #273

Closed

Conversation

manuel3108
Copy link
Member

@manuel3108 manuel3108 commented Nov 7, 2024

Relates #278

Obviously only merge once the issue above is implemented.

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: e31835f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 7, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@273

commit: e31835f

@paoloricciuti
Copy link
Member

Obviously only merge once the issue above is implemented.

You can't tell me what to do [merge]

😄 😄 😄

@@ -7,6 +7,7 @@ import { getUserAgent } from '../common.ts';
export const migrate = new Command('migrate')
.description('a CLI for migrating Svelte(Kit) codebases')
.argument('<migration>', 'migration to run')
.argument('[path]', 'component path or directory to migrate')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems confusing to me because I doubt that all the migrations will accept a path. I think the args should be dependent on the migration. For now I think I'd just pass the args through without trying to list them here

maybe after #274 is merged we can use the same CLI parsing library for both and share the args across packages or something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed a valid argument. Now that the migrate code is here, we can think about this directly while implementing #278

Closing here.

@manuel3108 manuel3108 closed this Nov 8, 2024
@manuel3108 manuel3108 deleted the feat/migrate-allow-passing-path-or-component branch November 8, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants